<html>
<head><meta charset="utf-8"><title>perf.rlo broken - script-servo benchmarks · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/perf.2Erlo.20broken.20-.20script-servo.20benchmarks.html">perf.rlo broken - script-servo benchmarks</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="184905324"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/perf.rlo%20broken%20-%20script-servo%20benchmarks/near/184905324" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/perf.2Erlo.20broken.20-.20script-servo.20benchmarks.html#184905324">(Jan 06 2020 at 13:25)</a>:</h4>
<p><a href="https://perf.rust-lang.org/status.html" target="_blank" title="https://perf.rust-lang.org/status.html">https://perf.rust-lang.org/status.html</a> shows <code>script-servo</code> compilation erroring with:</p>
<div class="codehilite"><pre><span></span>error: internal compiler error: mutable allocation in constant
    --&gt; /tmp/.tmpL9Kzt5/target/debug/build/script-76da5cd8e8022d4a/out/Bindings/AttrBinding.rs:1013:64
     |
1013 |   const sAttributes_specs: &amp;&#39;static [&amp;&#39;static[JSPropertySpec]] = &amp;[
     |  ________________________________________________________________^
1014 | | &amp;[
1015 | |     JSPropertySpec {
1016 | |         name: b&quot;namespaceURI\0&quot; as *const u8 as *const libc::c_char,
...    |
1081 | |
1082 | | ];
     | |_^
</pre></div>


<p><span class="user-group-mention" data-user-group-id="1916">@WG-const-eval</span> does that look correct to you?</p>



<a name="184905441"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/perf.rlo%20broken%20-%20script-servo%20benchmarks/near/184905441" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/perf.2Erlo.20broken.20-.20script-servo.20benchmarks.html#184905441">(Jan 06 2020 at 13:27)</a>:</h4>
<p><span class="user-mention" data-user-id="219747">@Simon Sapin</span>, do you know someone who could help fix this? It looks like the current version of Servo also has this code and might be hit by the same issue soon.</p>



<a name="184905730"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/perf.rlo%20broken%20-%20script-servo%20benchmarks/near/184905730" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/perf.2Erlo.20broken.20-.20script-servo.20benchmarks.html#184905730">(Jan 06 2020 at 13:30)</a>:</h4>
<p>I just found this: <a href="https://github.com/rust-lang/rust/issues/67601" target="_blank" title="https://github.com/rust-lang/rust/issues/67601">https://github.com/rust-lang/rust/issues/67601</a></p>



<a name="184905845"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/perf.rlo%20broken%20-%20script-servo%20benchmarks/near/184905845" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/perf.2Erlo.20broken.20-.20script-servo.20benchmarks.html#184905845">(Jan 06 2020 at 13:32)</a>:</h4>
<p>and the PR that will hopefully fix the issue: <a href="https://github.com/rust-lang/rust/pull/67603" target="_blank" title="https://github.com/rust-lang/rust/pull/67603">https://github.com/rust-lang/rust/pull/67603</a></p>



<a name="184910029"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/perf.rlo%20broken%20-%20script-servo%20benchmarks/near/184910029" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Simon Sapin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/perf.2Erlo.20broken.20-.20script-servo.20benchmarks.html#184910029">(Jan 06 2020 at 14:27)</a>:</h4>
<p>Yes, we’re also waiting on that PR to be able to upgrade the toolchain in Servo</p>



<a name="184913893"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/perf.rlo%20broken%20-%20script-servo%20benchmarks/near/184913893" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/perf.2Erlo.20broken.20-.20script-servo.20benchmarks.html#184913893">(Jan 06 2020 at 15:10)</a>:</h4>
<p>I've elected not to change the code in perf.rlo given that we expect a bug fix to the compiler soon, and it looked non-obvious that a targeted fix existed.</p>



<a name="184996195"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/perf.rlo%20broken%20-%20script-servo%20benchmarks/near/184996195" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/perf.2Erlo.20broken.20-.20script-servo.20benchmarks.html#184996195">(Jan 07 2020 at 09:59)</a>:</h4>
<p>yes, just waiting for the fix seems sensible</p>



<a name="185828411"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/perf.rlo%20broken%20-%20script-servo%20benchmarks/near/185828411" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/perf.2Erlo.20broken.20-.20script-servo.20benchmarks.html#185828411">(Jan 16 2020 at 16:01)</a>:</h4>
<p>Fixed <span aria-label="crab" class="emoji emoji-1f980" role="img" title="crab">:crab:</span></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>